Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp Refactoring: Merged multipliers that do the same thing #29293

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

Givikap120
Copy link
Contributor

This was made to avoid confusion - "which multiplier I have to change"?
Also, for consistency purposes all multipliers were renamed to difficulty_multiplier

@ppy ppy deleted a comment from github-actions bot Aug 7, 2024
@ppy ppy deleted a comment from github-actions bot Aug 7, 2024
@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=taiko

Copy link

github-actions bot commented Aug 7, 2024

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=catch

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=mania

Copy link

github-actions bot commented Aug 7, 2024

Copy link

github-actions bot commented Aug 7, 2024

@smoogipoo
Copy link
Contributor

Looks like a few changes in the catch sheet, albeit on an edge-case map (likely every map has some difference small enough to not appear in the sheet).

Speaking of, how were the catch changes calculated out?

@Givikap120
Copy link
Contributor Author

Looks like a few changes in the catch sheet, albeit on an edge-case map (likely every map has some difference small enough to not appear in the sheet).

Speaking of, how were the catch changes calculated out?

It's very weird that it had any change, because I checked #1 player profile - and he had 0 difference on all maps
what is expected because it had 900 skill multiplier
then sqrt(900) = 30
and 0.153 * 30 = 4.59

@Givikap120
Copy link
Contributor Author

Givikap120 commented Aug 7, 2024

looking on this - I think it's 100% floating point moment
because on website NM is already more than 100 stars, idk how DTHR can be only 40 stars
image

@Givikap120
Copy link
Contributor Author

Also, this score is indeed 232pp, not 231pp as sheet claims
image

@smoogipoo
Copy link
Contributor

Doesn't sqrt(900) assume there are only 900 strains?

@Givikap120
Copy link
Contributor Author

Doesn't sqrt(900) assume there are only 900 strains?

of course not
900 is just multiplier to strain
the number of strains have nothing to do with it

@smoogipoo smoogipoo merged commit 1beae4b into ppy:master Sep 12, 2024
9 checks passed
@Givikap120 Givikap120 deleted the pp_refactoring_merge_multipliers branch September 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Deployed
Development

Successfully merging this pull request may close these issues.

2 participants